linux-kernel - Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5429711C.4060008@suse.cz>
Date:	Mon, 29 Sep 2014 16:47:56 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	Valentin Rothberg <valentinrothberg@...il.com>,
	akpm@...ux-foundation.org,
	Stefan Hengelein <stefan.hengelein@....de>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python

On 2014-09-29 12:28, Paul Bolle wrote:
>> +STMT = r"^\s*(?:if|select|depends\s+on)\s+" + EXPR
> 
> Could please make that "depends on"? Yes, it seems the yacc grammar
> accepts any amount of whitespace, but that doesn't make it right to use
> anything other than a single space.

But then lines that violate coding style would not be checked for real
errors.


> (Can the yacc grammar be tweaked to
> see "depends on" as one, well, token?)

I don't think this is a good idea. This is a style issue, why make it a
grammar issue.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/