linux-kernel - Re: [PATCH v4 1/2] perf tool: encapsulate dsos list head into struct dsos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140929180727.GF3879@kernel.org>
Date:	Mon, 29 Sep 2014 15:07:27 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Waiman Long <waiman.long@...com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Scott J Norton <scott.norton@...com>,
	Douglas Hatch <doug.hatch@...com>,
	Don Zickus <dzickus@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH v4 1/2] perf tool: encapsulate dsos list head into struct
 dsos

Em Mon, Sep 29, 2014 at 01:26:55PM -0400, Waiman Long escreveu:
> On 09/26/2014 10:12 AM, Arnaldo Carvalho de Melo wrote:
> >Em Wed, Sep 24, 2014 at 11:45:39AM -0400, Waiman Long escreveu:
> >>This is a precursor patch to enable long name searching of DSOs
> >>using the rbtree. In this patch, a new dsos structure is created
> >>which contains only a list head structure for the moment. The new
> >>dsos structure is used, in turn, in the machine structure for the
> >>user_dsos and kernel_dsos fields. Only the following 3 dsos functions
> >>are modified to accept the new dsos structure parameter instead
> >>of list_head:
> >>  - dsos__add()
> >>  - dsos__find()
> >>  - __dsos__findnew()
> >>
> >>Because of the need to find out the corresponding dsos structure to
> >>properly call dsos__add() in dso__load_sym() of util/symbol-elf.c,
> >>a new dsos field is also added to the dso structure.
> >What tree did you use to produce these patches? I just tried on my
> >perf/core branch and I get some fuzzes:
> >
> >[acme@zoo linux]$ patch -p1<  /wb/1.patch
> >patching file tools/perf/util/dso.c
> >Hunk #1 succeeded at 755 (offset 2 lines).
> >Hunk #2 succeeded at 852 (offset 2 lines).
> >patching file tools/perf/util/dso.h
> >patching file tools/perf/util/header.c
> >patching file tools/perf/util/machine.c
> >Hunk #2 succeeded at 72 (offset 2 lines).
> >Hunk #3 succeeded at 477 (offset 29 lines).
> >Hunk #4 succeeded at 994 (offset 29 lines).
> >patching file tools/perf/util/machine.h
> >Hunk #2 succeeded at 39 with fuzz 1 (offset 1 line).
> >patching file tools/perf/util/probe-event.c
> >patching file tools/perf/util/symbol-elf.c
> >Hunk #1 succeeded at 929 (offset 13 lines).
> >[acme@zoo linux]$
> >
> >I'll fix this up, probably harmless, just a heads up.
> >
> >- Arnaldo
> 
> I was using the latest linux 3.17 tree. I should have used the tip tree
> instead. I will use that if I need to sent out a new patch.

Please do, tip/perf/urgent strictly for bug fixes, tip/perf/core for new
features or bug fixes for things that are only in tip/perf/core.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/