| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPp4yYxVSUMBBXdVPUETu=uM2K5P9GoeQjH0YgayVL2qco-gYg@mail.gmail.com> Date: Mon, 29 Sep 2014 11:13:13 -0700 From: Tong Shen <endlessroad@...gle.com> To: Namhyung Kim <namhyung@...nel.org> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, linux-perf-users@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/1] perf tools: Fix Symbol Address for ET_DYN On Sun, Sep 28, 2014 at 7:33 PM, Namhyung Kim <namhyung@...nel.org> wrote: > > Hmm.. IIUC for normal dso (ET_DYN), shdr->offset == shdr->sh_addr for > text section right? And we always adjust ET_EXEC and ET_REL.. What > about always trying to adjust symbol address then? We may precalculate > adjust offset and subtracting it from symbol values. And the offset of > 0 effectively means no adjust. This way we can simplify the logic IMHO. Yeah I'd like to do that too; but (shdr->offset == shdr->sh_addr for normal ET_DYN && shdr->offset != shdr->sh_addr for non-relocatable ET_DYN) is only true for .text section. It does not hold for .data section. I didn't dig deep into the code; if we only care about symbols in .text section (function names), we can do what you said. Otherwise we may want to keep it the way it is... -- Best Regards, Tong Shen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists