linux-kernel - Re: [PATCH v4 1/2] perf tool: encapsulate dsos list head into struct dsos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5429A7AE.9030707@hp.com>
Date:	Mon, 29 Sep 2014 14:40:46 -0400
From:	Waiman Long <waiman.long@...com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Scott J Norton <scott.norton@...com>,
	Douglas Hatch <doug.hatch@...com>,
	Don Zickus <dzickus@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH v4 1/2] perf tool: encapsulate dsos list head into struct
 dsos

On 09/29/2014 02:09 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 29, 2014 at 01:30:07PM -0400, Waiman Long escreveu:
>> On 09/28/2014 11:54 PM, Namhyung Kim wrote:
>>> On Fri, 26 Sep 2014 11:06:25 -0300, Arnaldo Carvalho de Melo wrote:
>>>> Em Wed, Sep 24, 2014 at 11:45:39AM -0400, Waiman Long escreveu:
>>>>> This is a precursor patch to enable long name searching of DSOs
>>>>> using the rbtree. In this patch, a new dsos structure is created
>>>>> which contains only a list head structure for the moment. The new
>>>>> dsos structure is used, in turn, in the machine structure for the
>>>>> user_dsos and kernel_dsos fields. Only the following 3 dsos functions
>>>>> are modified to accept the new dsos structure parameter instead
>>>>> of list_head:
>>>>>   - dsos__add()
>>>>>   - dsos__find()
>>>>>   - __dsos__findnew()
>>>>>
>>>>> Because of the need to find out the corresponding dsos structure to
>>>>> properly call dsos__add() in dso__load_sym() of util/symbol-elf.c,
>>>>> a new dsos field is also added to the dso structure.
>>>> Argh, yeah, that is unfortunate that we need to add entries that deep
>>>> inside dso__load_syms() :-\
>>> But it seems we can use map->groups->machine to find out the head/root
>>> of the dsos..
>> There are 2 dsos at the machine structure level - user_dsos and kernel_dsos.
>> In this particular case, it should be kernel_dsos. I can remove the dsos
>> pointer and hardcode it to use the kernel_dsos if you guys think it is
>> acceptable.
> Yes, I think that if we have already how to obtain the head/root where
> we want to insert things from structures present at that point in the
> code, no need to add it to the per-dso data structure.
>
> Thanks to Namhyung for finding an existing way of getting to the needed
> data structures.
>
> - Arnaldo

Sure, I will send out a new patch which includes the suggested change.

Thanks for the review.

-Longman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/