linux-kernel - Re: [PATCH v2] net: stmmac: fix stmmac_pci_probe failed when CONFIG_HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140929.163720.1059434932375001698.davem@davemloft.net>
Date:	Mon, 29 Sep 2014 16:37:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hock.leong.kweh@...el.com
Cc:	peppe.cavallaro@...com, rayagond@...avyalabs.com,
	vbridgers2013@...il.com, wens@...e.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, boon.leong.ong@...el.com,
	tobias.johannes.klausmann@....thm.de
Subject: Re: [PATCH v2] net: stmmac: fix stmmac_pci_probe failed when
 CONFIG_HAVE_CLK is selected

From: Kweh Hock Leong <hock.leong.kweh@...el.com>
Date: Fri, 26 Sep 2014 21:42:55 +0800

> From: "Kweh, Hock Leong" <hock.leong.kweh@...el.com>
> 
> When the CONFIG_HAVE_CLK is selected for the system, the stmmac_pci_probe
> will fail with dmesg:
> [    2.167225] stmmaceth 0000:00:14.6: enabling device (0000 -> 0002)
> [    2.178267] stmmaceth 0000:00:14.6: enabling bus mastering
> [    2.178436] stmmaceth 0000:00:14.6: irq 24 for MSI/MSI-X
> [    2.178703] stmmaceth 0000:00:14.6: stmmac_dvr_probe: warning: cannot
> get CSR clock
> [    2.186503] stmmac_pci_probe: main driver probe failed
> [    2.194003] stmmaceth 0000:00:14.6: disabling bus mastering
> [    2.196473] stmmaceth: probe of 0000:00:14.6 failed with error -2
> 
> This patch fix the issue by breaking the dependency to devm_clk_get()
> as the CSR clock can be obtained at priv->plat->clk_csr from pci driver.
> 
> Reported-by: Tobias Klausmann <tobias.johannes.klausmann@....thm.de>
> Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@...el.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/