linux-kernel - Re: [PATCH] powerpc/fsl: Add support for pci(e) machine check exception on E500MC / E5500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D04F3201.10DEB%jojyv@juniper.net>
Date:	Mon, 29 Sep 2014 23:03:37 +0000
From:	Jojy Varghese <jojyv@...iper.net>
To:	Guenter Roeck <linux@...ck-us.net>,
	Scott Wood <scottwood@...escale.com>
CC:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Guenter Roeck <groeck@...iper.net>,
	"hongtao.jia@...escale.com" <hongtao.jia@...escale.com>
Subject: Re: [PATCH] powerpc/fsl: Add support for pci(e) machine check
 exception on E500MC / E5500



On 9/29/14 12:06 PM, "Guenter Roeck" <linux@...ck-us.net> wrote:

>On Mon, Sep 29, 2014 at 01:36:06PM -0500, Scott Wood wrote:
>> On Mon, 2014-09-29 at 09:48 -0700, Guenter Roeck wrote:
>> > From: Jojy G Varghese <jojyv@...iper.net>
>> > 
>> > For E500MC and E5500, a machine check exception in pci(e) memory space
>> > crashes the kernel.
>> > 
>> > Testing shows that the MCAR(U) register is zero on a MC exception for
>>the
>> > E5500 core. At the same time, DEAR register has been found to have the
>> > address of the faulty load address during an MC exception for this
>>core.
>> > 
>> > This fix changes the current behavior to fixup the result register
>> > and instruction pointers in the case of a load operation on a faulty
>> > PCI address.
>> > 
>> > The changes are:
>> > - Added the hook to pci machine check handing to the e500mc machine
>>check
>> >   exception handler.
>> > - For the E5500 core, load faulting address from SPRN_DEAR register.
>> >   As mentioned above, this is necessary because the E5500 core does
>>not
>> >   report the fault address in the MCAR register.
>> > 
>> > Cc: Scott Wood <scottwood@...escale.com>
>> > Signed-off-by: Jojy G Varghese <jojyv@...iper.net>
>> > [Guenter Roeck: updated description]
>> > Signed-off-by: Guenter Roeck <groeck@...iper.net>
>> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> > ---
>> >  arch/powerpc/kernel/traps.c   | 3 ++-
>> >  arch/powerpc/sysdev/fsl_pci.c | 5 +++++
>> >  2 files changed, 7 insertions(+), 1 deletion(-)
>> > 
>> > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
>> > index 0dc43f9..ecb709b 100644
>> > --- a/arch/powerpc/kernel/traps.c
>> > +++ b/arch/powerpc/kernel/traps.c
>> > @@ -494,7 +494,8 @@ int machine_check_e500mc(struct pt_regs *regs)
>> >  	int recoverable = 1;
>> >  
>> >  	if (reason & MCSR_LD) {
>> > -		recoverable = fsl_rio_mcheck_exception(regs);
>> > +		recoverable = fsl_rio_mcheck_exception(regs) ||
>> > +			fsl_pci_mcheck_exception(regs);
>> >  		if (recoverable == 1)
>> >  			goto silent_out;
>> >  	}
>> > diff --git a/arch/powerpc/sysdev/fsl_pci.c
>>b/arch/powerpc/sysdev/fsl_pci.c
>> > index c507767..bdb956b 100644
>> > --- a/arch/powerpc/sysdev/fsl_pci.c
>> > +++ b/arch/powerpc/sysdev/fsl_pci.c
>> > @@ -1021,6 +1021,11 @@ int fsl_pci_mcheck_exception(struct pt_regs
>>*regs)
>> >  #endif
>> >  	addr += mfspr(SPRN_MCAR);
>> >  
>> > +#ifdef CONFIG_E5500_CPU
>> > +	if (mfspr(SPRN_EPCR) & SPRN_EPCR_ICM)
>> > +		addr = PFN_PHYS(vmalloc_to_pfn((void *)mfspr(SPRN_DEAR)));
>> > +#endif
>> 
>> Kconfig tells you what hardware is supported, not what hardware you're
>> actually running on.
>> 
>Hi Scott,
>
>Good point. Jojy, guess we'll have to check if the CPU is actually an
>E5500.
>Can you look into that ?


"/proc/cpuinfo" shows the cpu as "e5500". Scott, are you suggesting that
we use a runtime method of determining the cpu type (cpu_spec's cpu_name
for
example).  


>
>> Jia Hongtao, do you know anything about this issue?  Is there an
>> erratum?  What chips are affected by the the erratum covered by
>> <http://patchwork.ozlabs.org/patch/240239/>?
>> 
>We already have and use the above patch(es) in our kernel. It works fine
>for E500 (P2020), but does not address E5500 (P5020/P5040).
>
>> Can we rely on DEAR or is this just a side effect of likely having taken
>> a TLB miss for the address recently?  Perhaps we should use the
>> instruction emulation to determine the effective address instead.
>> 
>> Guenter, is this patch intended to deal with an erratum or are you
>> covering up legitimate errors?
>> 
>Those are errors related to PCIe hotplug, and are seen with unexpected
>PCIe
>device removals (triggered, for example, by removing power from a PCIe
>adapter).
>The behavior we see on E5500 is quite similar to the same behavior on
>E500:
>If unhandled, the CPU keeps executing the same instruction over and over
>again
>if there is an error on a PCIe access and thus stalls. I don't know if
>this
>is considered an erratum or expected behavior, but it is one we have to
>address
>since we have to be able to handle that condition. Ultimately, we'll want
>to
>implement PCIe error handlers for the affected drivers, but that will be
>a next
>step.

According to the spec, we MCAR is supposed to hold the faulty data address
but for 5500 core, we found that MCAR is zero. You are right that DEAR
entry could
be a resultOf a TLB miss but that¹s the register we could rely on.

What do you mean by "instruction emulation"? Are you suggesting that we
examine the RD, RS 
registers for the instruction?



>
>Please let me know if you have a better solution to address this problem.
>
>Thanks,
>Guenter


Thanks
Jojy