linux-kernel - Re: [PATCH] staging: skein: Fixed Conditional white space problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Sep 2014 21:00:11 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Eric Rost <eric.rost@...abylon.net>
Cc:	Greg KH <gregkh@...uxfoundation.org>, jake@....net,
	antonysaraev@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: skein: Fixed Conditional white space problems

Eric,

On Mon, Sep 29, 2014 at 07:40:11PM -0500, Eric Rost wrote:
> > >I'll be looking to see that no object
> > code has changed (./scripts/objdiff) across your patch series.
> 
> Hmm... I'm thinking of digging into it, but I'm not sure the #if's can
> be gotten rid of sans object code changes, since its picking codeblocks
> in the precompiler stage, right?

You just have to remain consistent with what's currently being selected.
But yes, you are correct.

And don't get yourself too tied up in knots wrt objdiff-perfection.  I
would take a look at what Joe Perches posted as a starting point.  I
haven't reviewed it in depth yet as I'm wrapped around the axle with
other commitments.

If you get stuck, just ask.  A *little* beating your head against the
wall is part of the learning process, a lot is just unnecessary
frustration.

wrt to this code, we don't necessarily need to see the macros and such
removed.  First step, get them out of the middle of functions.  Second
step, decide which would be better off as static inline functions.  The
rest may be able to go into a common include.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/