linux-kernel - Re: [PATCH v13 00/12] Support for creating generic PCI host bridges from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140930103942.GO841@e106497-lin.cambridge.arm.com>
Date:	Tue, 30 Sep 2014 11:39:42 +0100
From:	Liviu Dudau <Liviu.Dudau@....com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Arnd Bergmann <arnd@...db.de>, Rob Herring <robh+dt@...nel.org>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Catalin Marinas <Catalin.Marinas@....com>,
	Will Deacon <Will.Deacon@....com>,
	Russell King <linux@....linux.org.uk>,
	linux-pci <linux-pci@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Tanmay Inamdar <tinamdar@....com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Sinan Kaya <okaya@...eaurora.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Suravee Suthikulanit <suravee.suthikulpanit@....com>,
	linux-arch <linux-arch@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Device Tree ML <devicetree@...r.kernel.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>,
	Yinghai Lu <yinghai@...nel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>
Subject: Re: [PATCH v13 00/12] Support for creating generic PCI host bridges
 from DT

On Mon, Sep 29, 2014 at 08:43:35PM +0100, Bjorn Helgaas wrote:
> On Mon, Sep 29, 2014 at 03:29:19PM +0100, Liviu Dudau wrote:
> > This is my version 13 of the attempt at adding support for generic PCI host
> > bridge controllers. It contains only cleanups to make it play nice with the
> > linux-next tree as of 09/25. If Bjorn deems it safe, now that it looks like
> > asm-generic is going to revert some of its more aggresive patches, he has the
> > choice of queueing it into linux-next again.
> > ...
> 
> These patches above were already on my pci/host-generic branch and in
> linux-next:
> 
>    asm-generic/io.h: Fix ioport_map() for !CONFIG_GENERIC_IOMAP
This ^ ...

>    of/pci: Add pci_register_io_range() and pci_pio_to_address()
>    ARM: Define PCI_IOBASE as the base of virtual PCI IO space

and this ^ need to be refreshed from my series otherwise we will get conflicts with
asm-generic branch (either now or in the future). While the asm-generic/io.h
cast is arguably superflous, we need to define PCI_IOBASE as a void __iomem* to
match all other standard declarations of PCI_IOBASE.

>    of/pci: Define of_pci_range_to_resource() only when CONFIG_PCI=y
>    of/pci: Move of_pci_range_to_resources() to of/address.c
>    of/pci: Fix the conversion of IO ranges into IO resources
> 
> I added these three patches to my pci/host-generic branch:
> 
>    PCI: Add generic domain handling
>    of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr()
>    of/pci: Add support for parsing PCI host bridge resources from DT

I can see these patches added to pci/host-generic but not on pci/next.

> 
> Yinghai pointed out a problem with this one, so I omitted it:
> 
>    PCI: Assign unassigned bus resources in pci_scan_root_bus()

Thats fine, host bridge drivers will have to work around pci_scan_root_bus() reduced
functionality for now.


> 
> I added this one to my pci/host-generic branch:
> 
>    PCI: Add pci_remap_iospace() to map bus I/O resources
> 
> I assume this depends on the pci_scan_root_bus() change (if not, let me
> know), so I omitted this one:
> 
>    arm64: Add architectural support for PCI

No, there is no dependency there on pci_scan_root_bus(), it can go in the series.
The only thing that depends on a feature rich pci_scan_root_bus() is the host
bridge driver in order to be able to use only one line to process the root bus.

Thanks for huge support in getting these patches in and I do hope I'm not being
too much of a burden to you.

Best regards,
Liviu

> 
> Bjorn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/