linux-kernel - Re: [PATCH v2] i2c: move acpi code back into the core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140930125520.61b57882@endymion.delvare>
Date:	Tue, 30 Sep 2014 12:55:20 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	linux-i2c@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Lan Tianyu <tianyu.lan@...el.com>
Subject: Re: [PATCH v2] i2c: move acpi code back into the core

Hi Wolfram,

Sorry for the late reply, I was on the road for most of the past 2
weeks.

On Wed, 24 Sep 2014 23:36:31 +0200, Wolfram Sang wrote:
> Commit 5d98e61d337c ("I2C/ACPI: Add i2c ACPI operation region support")
> renamed the i2c-core module. This may cause regressions for
> distributions, so put the ACPI code back into the core.
> 
> Reported-by: Jean Delvare <jdelvare@...e.de>
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Lan Tianyu <tianyu.lan@...el.com>
> Cc: Jean Delvare <jdelvare@...e.de>
> ---
> 
> v2: - make all acpi functions static
>     - annotate #endif
>     - remove declarations in i2c.h
>     - add dummy functions to i2c-core.c
>     - make two seperate #ifdef blocks instead of two nested ones
>       (otherwise build errors due to no external decl. anymore)
> 
> Mika, Lan, Jean: please test/review. I am still waiting for some testbot
> results, yet your audit is very wanted.

I see that the patch is already upstream. Nevertheless I reviewed the
integration part of it and it looks OK to me. Thanks for doing that!

The only thing which I find curious is that ACPI_I2C_OPREGION depends
on I2C=y. Is this limitation a leftover from when the code was split to
a separate file? It builds just fine with I2C=m, and I can't see why it
wouldn't work. I have a patch to enable that, I can send it if it is
the right thing to do. But maybe I'm missing something?

Thanks again,
-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/