lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140930.164533.2014251085729375033.davem@davemloft.net>
Date:	Tue, 30 Sep 2014 16:45:33 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hau@...ltek.com
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 08/10] r8169:change function name of function
 "r8168dp_check_dash" to "r8168_check_dash"

From: Chun-Hao Lin <hau@...ltek.com>
Date: Tue, 30 Sep 2014 23:00:28 +0800

> @@ -4364,7 +4364,7 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
>  	if ((tp->mac_version == RTL_GIGA_MAC_VER_27 ||
>  	     tp->mac_version == RTL_GIGA_MAC_VER_28 ||
>  	     tp->mac_version == RTL_GIGA_MAC_VER_31) &&
> -	    r8168dp_check_dash(tp)) {
> +	     r8168_check_dash(tp)) {

You are breaking the indentation here, "r8169_check_dash..." should start exactly
at the first column after the openning parenthesis of the if() statement.

So that's a TAB and four SPACE characters, not five SPACE characters.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ