linux-kernel - Re: [PATCH 2/2] led: remove use of gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK5ve-KCYHySjs4f+rd+kAvKQmTkJqsq87Muq_j-D0nB7WSYjQ@mail.gmail.com>
Date:	Tue, 30 Sep 2014 14:21:45 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav
<pramod.gurav@...rtplayin.com> wrote:
> Get rid of using return value from gpiochip_remove() as it returns
> void.
>

Looks good to me. I will merge it.

But what's in the first patch. I just got this second patch in my email inbox.

-Bryan

> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: Bryan Wu <cooloney@...il.com>
> Cc: Richard Purdie <rpurdie@...ys.net>
> Cc: linux-leds@...r.kernel.org
>
> Cc: linux-gpio@...r.kernel.org
>
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>
> ---
>  drivers/leds/leds-pca9532.c |   10 ++--------
>  drivers/leds/leds-tca6507.c |    7 ++-----
>  2 files changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index 4a0e786..5a6363d 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -319,14 +319,8 @@ static int pca9532_destroy_devices(struct pca9532_data *data, int n_devs)
>         }
>
>  #ifdef CONFIG_LEDS_PCA9532_GPIO
> -       if (data->gpio.dev) {
> -               int err = gpiochip_remove(&data->gpio);
> -               if (err) {
> -                       dev_err(&data->client->dev, "%s failed, %d\n",
> -                                               "gpiochip_remove()", err);
> -                       return err;
> -               }
> -       }
> +       if (data->gpio.dev)
> +               gpiochip_remove(&data->gpio);
>  #endif
>
>         return 0;
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index 3d9e267..20fa8e7 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -667,11 +667,8 @@ static int tca6507_probe_gpios(struct i2c_client *client,
>
>  static void tca6507_remove_gpio(struct tca6507_chip *tca)
>  {
> -       if (tca->gpio.ngpio) {
> -               int err = gpiochip_remove(&tca->gpio);
> -               dev_err(&tca->client->dev, "%s failed, %d\n",
> -                       "gpiochip_remove()", err);
> -       }
> +       if (tca->gpio.ngpio)
> +               gpiochip_remove(&tca->gpio);
>  }
>  #else /* CONFIG_GPIOLIB */
>  static int tca6507_probe_gpios(struct i2c_client *client,
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/