linux-kernel - [PATCH v2] net: ll_temac: Remove unnecessary ether_setup after alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <909ad6e2f067c956a2bb89d848a2fc38fc605a08.1412154072.git.michal.simek@xilinx.com>
Date:	Wed,  1 Oct 2014 11:01:17 +0200
From:	Michal Simek <michal.simek@...inx.com>
To:	linux-kernel@...r.kernel.org, monstr@...str.eu
Cc:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>,
	"David S. Miller" <davem@...emloft.net>,
	Manuel Schölling <manuel.schoelling@....de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Joe Perches <joe@...ches.com>,
	Ricardo Ribalda <ricardo.ribalda@...il.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: [PATCH v2] net: ll_temac: Remove unnecessary ether_setup after alloc_etherdev

From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>

Calling ether_setup is redundant since alloc_etherdev calls it.

Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
Signed-off-by: Michal Simek <michal.simek@...inx.com>
---

Changes in v2:
- Remove axienet because it is already applied in separate patch
  https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=c706471b2601d1c9058e7b866db77f6eb7dd37af

 drivers/net/ethernet/xilinx/ll_temac_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index fda5891835d4..629077050fce 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op)
 	if (!ndev)
 		return -ENOMEM;

-	ether_setup(ndev);
 	platform_set_drvdata(op, ndev);
 	SET_NETDEV_DEV(ndev, &op->dev);
 	ndev->flags &= ~IFF_MULTICAST;  /* clear multicast */
--
1.8.2.3


Content of type "application/pgp-signature" skipped