linux-kernel - Re: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141001114524.GU4273@sirena.org.uk>
Date:	Wed, 1 Oct 2014 12:45:24 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Opensource [James Seong-Won Ban]" <James.Ban.opensource@...semi.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Support Opensource <Support.Opensource@...semi.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>
Subject: Re: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit

On Wed, Oct 01, 2014 at 01:02:27AM +0000, Opensource [James Seong-Won Ban] wrote:

> > Applied, but please try to make sure that your changelogs are more
> > descriptive - what is the bug?  Please also use subject lines matching
> > the style for the subsystem.

> The proper operation of mask bit should be set as '0' for enabling the interrupt.
> The result of mask operation at previous code was the same to new one.
> But the meaning in the previous code was to set mask bit as '1'.

Right, the point is that this information should've gone in the
changelog - please bear this in mind for future patches.

> What is subject line you said?
> If you give me an example, it would be very helpful to me.

git shortlog drivers/regulator.  The capitalisation and extra spaces are
both off.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)