linux-kernel - Re: [PATCH] vfio/pci: Add missing linux/irq.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1412183666.7360.226.camel@ul30vt.home>
Date:	Wed, 01 Oct 2014 11:14:26 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio/pci: Add missing linux/irq.h include

On Wed, 2014-10-01 at 14:00 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> This code uses the irq_get_msi_desc() function whose prototype is in
> linux/irq.h. Include this header to fix a build failure.
> 
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  drivers/vfio/pci/vfio_pci_intrs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index a068bb0d69e5..d6f097b0e0e3 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> @@ -15,6 +15,7 @@
>  
>  #include <linux/device.h>
>  #include <linux/interrupt.h>
> +#include <linux/irq.h>
>  #include <linux/eventfd.h>
>  #include <linux/msi.h>
>  #include <linux/pci.h>

Hi Thierry, thanks for the patch.  The call to irq_get_msi_desc()
actually came in as part of a conflict resolution in the next tree.
I've requested that the next spin of linux-next include this header if
the conflict still exists, but I'm also working to make the conflict go
away along with the function call that requires this additional header.
Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/