linux-kernel - Re: [PATCH] HID: uHID: fix excepted report type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1410012101350.26311@pobox.suse.cz>
Date:	Wed, 1 Oct 2014 21:01:52 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	David Herrmann <dh.herrmann@...il.com>
cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	David Herrmann <dh.herrmann@...glemail.com>,
	"open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: uHID: fix excepted report type

On Wed, 1 Oct 2014, David Herrmann wrote:

> > diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
> > index f6ec5ea..e094c57 100644
> > --- a/drivers/hid/uhid.c
> > +++ b/drivers/hid/uhid.c
> > @@ -154,7 +154,7 @@ static int __uhid_report_queue_and_wait(struct uhid_device *uhid,
> >
> >         spin_lock_irqsave(&uhid->qlock, flags);
> >         *report_id = ++uhid->report_id;
> > -       uhid->report_type = ev->type;
> > +       uhid->report_type = ev->type + 1;
> 
> Nice catch. We always need the *_REPLY type as response:
> 
> Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/