linux-kernel - Re: [PATCH] staging: rts5208: Clean up coding style in rtsx_chip.c to get rid of checkpatch.pl warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 Oct 2014 11:12:50 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Giedrius Statkevicius <giedrius.statkevicius@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, mahati.chamarthy@...il.com,
	fabio.falzoi84@...il.com
Subject: Re: [PATCH] staging: rts5208: Clean up coding style in rtsx_chip.c
 to get rid of checkpatch.pl warnings

On Thu, Oct 02, 2014 at 01:12:35AM +0300, Giedrius Statkevicius wrote:
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index 1411471..d604341 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -291,7 +291,9 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
>  		if (chip->dynamic_aspm) {
>  			if (CHK_SDIO_EXIST(chip)) {
>  				if (CHECK_PID(chip, 0x5288)) {

These two conditions can be combined and the indenting pulled in one
tab.

  			if (CHK_SDIO_EXIST(chip) && CHECK_PID(chip, 0x5288)) {


 			}
> @@ -988,8 +995,10 @@ void rtsx_polling_func(struct rtsx_chip *chip)
>  
>  			turn_off_led(chip, LED_GPIO);
>  
> -			if (chip->auto_power_down && !chip->card_ready && !chip->sd_io)
> -				rtsx_force_power_down(chip, SSC_PDCTL | OC_PDCTL);
> +			if (chip->auto_power_down && !chip->card_ready &&
> +					!chip->sd_io)

Line this up like this:

			if (chip->auto_power_down && !chip->card_ready &&
			    !chip->sd_io)
[tab][tab][tab][space][space][space][space]!chip->sd_io)


> +				rtsx_force_power_down(chip,
> +						SSC_PDCTL | OC_PDCTL);
>  
>  		}
>  	}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/