linux-kernel - Re: [PATCH V2] Staging: rtl8712 removed unnecessary else after return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141002084745.GF23154@mwanda>
Date:	Thu, 2 Oct 2014 11:47:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Nitin Kuppelur <nitinkuppelur@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] Staging: rtl8712 removed unnecessary else after return

On Thu, Oct 02, 2014 at 09:44:06AM +0200, Nitin Kuppelur wrote:
> Removed unnecessary else after return to solve
> checkpatch.pl warning
> 
> Signed-off-by: Nitin Kuppelur <nitinkuppelur@...il.com>
> ---
>  drivers/staging/rtl8712/hal_init.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
> index 81cd654..e5878e2 100644
> --- a/drivers/staging/rtl8712/hal_init.c
> +++ b/drivers/staging/rtl8712/hal_init.c
> @@ -387,12 +387,9 @@ uint rtl8712_hal_deinit(struct _adapter *padapter)
>  uint rtl871x_hal_init(struct _adapter *padapter)
>  {
>  	padapter->hw_init_completed = false;
> -	if (padapter->halpriv.hal_bus_init == NULL)
> +	if (padapter->halpriv.hal_bus_init == NULL ||
> +		padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
>  		return _FAIL;

Align these like this:

	if (padapter->halpriv.hal_bus_init == NULL ||
	    padapter->halpriv.hal_bus_init(padapter) != _SUCCESS) 
		return _FAIL;
[tab][space][space][space][space]padapter->halpriv.hal_bus_init...

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/