linux-kernel - Re: [Linux-ima-devel] [PATCH v2 3/4] ima: check appraisal flag in the ima_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <542D4F4B.90400@samsung.com>
Date:	Thu, 02 Oct 2014 16:12:43 +0300
From:	Dmitry Kasatkin <d.kasatkin@...sung.com>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	Roberto Sassu <roberto.sassu@...ito.it>
Cc:	Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
	linux-ima-devel@...ts.sourceforge.net,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Linux-ima-devel] [PATCH v2 3/4] ima: check appraisal flag in the
 ima_file_free() hook

On 02/10/14 16:03, Mimi Zohar wrote:
>> Ok, thanks.
>> > 
>> > Acked-by: Roberto Sassu <roberto.sassu@...ito.it>
>> > 
>> > Roberto Sassu
> Thanks, Dmitry, Roberto.  The patch and update description looks good.
> Please post the updated patch inline here on the mailing list.
>
> thanks,
>
> Mimi
>
>

Mimi, patch is the same what I posted 9:21 GMT and what Roberto acked.
Patch description updated based on Roberto's and Your comments

    ima: check ima_policy_flag in the ima_file_free() hook
   
    This patch completes the switching to the 'ima_policy_flag' variable
    in the checks at the beginning of IMA functions, starting with the
    commit a756024e.
   
    Checking 'iint_initialized' is completely unnecessary, because
    S_IMA flag is unset if iint was not allocated. At the same time
    the integrity cache is allocated with SLAB_PANIC and the kernel will
    panic if the allocation fails during kernel initialization. So on
    a running system iint_initialized is always true and can be removed.
   
    Changes in v3:
    * not limiting test to IMA_APPRAISE (spotted by Roberto Sassu)
   
    Changes in v2:
    * 'iint_initialized' removal patch merged to this patch (requested
       by Mimi)
   
    Signed-off-by: Dmitry Kasatkin <d.kasatkin@...sung.com>
    Acked-by: Roberto Sassu <roberto.sassu@...ito.it>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/