linux-kernel - Re: [PATCH v3.1 1/5] perf report: Set callchain_param.record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141002134606.GI9764@krava.brq.redhat.com>
Date:	Thu, 2 Oct 2014 15:46:06 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Jean Pihet <jean.pihet@...aro.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH v3.1 1/5] perf report: Set callchain_param.record_mode
 for future use

On Thu, Oct 02, 2014 at 12:12:14PM +0900, Namhyung Kim wrote:
> Normally the callchain_param.record_mode is used only for record path.
> But as it might need to prepare something for dwarf unwinding, setup
> this info for perf report too.
> 
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Jean Pihet <jean.pihet@...aro.org>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-report.c     | 6 ++++++
>  tools/perf/tests/dwarf-unwind.c | 3 +++
>  tools/perf/util/callchain.h     | 2 ++
>  tools/perf/util/hist.h          | 2 --
>  4 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index ac145fae0521..495168e73d4a 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -257,6 +257,12 @@ static int report__setup_sample_type(struct report *rep)
>  		}
>  	}
>  
> +	if (symbol_conf.use_callchain || symbol_conf.cumulate_callchain) {
> +		if (sample_type & PERF_SAMPLE_REGS_USER)

should we check also for PERF_SAMPLE_STACK_USER?
as in machine__resolve_callchain

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/