linux-kernel - Re: [PATCH] mm: fremap use linux header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 02 Oct 2014 12:23:34 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Paul McQuade <paulmcquad@...il.com>
CC:	akpm@...ux-foundation.org, hughd@...gle.com, gorcunov@...nvz.org,
	kirill.shutemov@...ux.intel.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: fremap use linux header

On 10/02/2014 11:34 AM, Paul McQuade wrote:
> Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>

linux/mmu_context.h does not include asm/mmu_context.h

This leads me to believe that either fremap.c does not use
any definitions from either mmu_context.h file, or after
your change the code that fremap.c needs is no longer directly
included (but only imported indirectly due to sheer luck).

Could you verify which of these is the case?

If fremap.c is not using any code from mmu_context.h, we are
better off simply removing that line, instead of replacing it
with an unnecessary include...

> diff --git a/mm/fremap.c b/mm/fremap.c
> index 72b8fa3..d614f1c 100644
> --- a/mm/fremap.c
> +++ b/mm/fremap.c
> @@ -1,6 +1,6 @@
>  /*
>   *   linux/mm/fremap.c
> - * 
> + *
>   * Explicit pagetable population and nonlinear (random) mappings support.
>   *
>   * started by Ingo Molnar, Copyright (C) 2002, 2003
> @@ -16,8 +16,8 @@
>  #include <linux/rmap.h>
>  #include <linux/syscalls.h>
>  #include <linux/mmu_notifier.h>
> +#include <linux/mmu_context.h>
>  
> -#include <asm/mmu_context.h>
>  #include <asm/cacheflush.h>
>  #include <asm/tlbflush.h>
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/