linux-kernel - Re: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1412270771.20184.1.camel@lolumad>
Date:	Thu, 02 Oct 2014 19:26:11 +0200
From:	Rostislav Lisovy <lisovy@...il.com>
To:	Hartley Sweeten <HartleyS@...ionengravers.com>
Cc:	Chen Gang <gang.chen.5i5j@...il.com>,
	"abbotti@....co.uk" <abbotti@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"luca.ellero@...ckedbrain.com" <luca.ellero@...ckedbrain.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Richard Weinberger <richard@....at>
Subject: Re: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC
 depend on HAS_IOMEM

On Thu, 2014-10-02 at 17:01 +0000, Hartley Sweeten wrote:
> On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote:
> > COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> > with allmodconfig under um):
> >
> >     CC [M]  drivers/staging/comedi/drivers/ii_pci20kc.o
> >   drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
> >   drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> >     dev->mmio = ioremap(membase, II20K_SIZE);
> >     ^
> >   drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
> >     dev->mmio = ioremap(membase, II20K_SIZE);
> >               ^
> >   drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
> >   drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> >      iounmap(dev->mmio);
> >      ^
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> > ---
> >  drivers/staging/comedi/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> > index a8bc2b5..b709736 100644
> > --- a/drivers/staging/comedi/Kconfig
> > +++ b/drivers/staging/comedi/Kconfig
> > @@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16
> >  
> >  config COMEDI_II_PCI20KC
> >  	tristate "Intelligent Instruments PCI-20001C carrier support"
> > +	depends on HAS_IOMEM
> >  	---help---
> >  	  Enable support for Intelligent Instruments PCI-20001C carrier
> >  	  PCI-20001, PCI-20006 and PCI-20341
> 
> This seems appropriate.
> 
> Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> 

Since "egrep -irn "ioremap" drivers/staging/comedi/drivers | wc -l"
shows "39" does it mean that this should be added to all the other
drivers as well?

Rostislav Lisovy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/