linux-kernel - Re: [PATCH] acct: fix build warning when ACCT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141002215531.GA5259@hercules>
Date:	Thu, 2 Oct 2014 22:55:31 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] acct: fix build warning when ACCT_VERSION != 3

On Thu, Oct 02, 2014 at 02:09:45PM -0700, Andrew Morton wrote:
> On Thu, 2 Oct 2014 00:06:53 +0100 Luis Henriques <luis.henriques@...onical.com> wrote:
> 
> > struct pid_namespace *ns is used only when ACCT_VERSION is 3.
> > 
> > kernel/acct.c:475:24: warning: unused variable 'ns' [-Wunused-variable]
> > 
> > Signed-off-by: Luis Henriques <luis.henriques@...onical.com>
> > ---
> >  kernel/acct.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/kernel/acct.c b/kernel/acct.c
> > index b4c667d22e79..5f277f5c5e29 100644
> > --- a/kernel/acct.c
> > +++ b/kernel/acct.c
> > @@ -472,7 +472,9 @@ static void do_acct_process(struct bsd_acct_struct *acct)
> >  	acct_t ac;
> >  	unsigned long flim;
> >  	const struct cred *orig_cred;
> > +#if ACCT_VERSION == 3
> >  	struct pid_namespace *ns = acct->ns;
> > +#endif
> >  	struct file *file = acct->file;
> >  
> >  	/*
> 
> It's always a good idea to check linux-next.  This has been addressed by
> http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning.patch
> http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning-fix.patch
> 
> 

Ah, awesome!  I missed these patches.  Thanks Andrew.

Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/