linux-kernel - Re: [PATCH] Staging: rtl8712 removed unnecessary else after return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <542D013E.6030800@gmail.com>
Date:	Thu, 02 Oct 2014 09:39:42 +0200
From:	Nitin Kuppelur <nitinkuppelur@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8712 removed unnecessary else after return

> 
> Perhaps a more common style is to use:
> 
> 	if (!padapter->halpriv.hal_bus_init ||
> 	    padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> 		return _FAIL;
> 
> 
Agreed. I will send updated patch.

Regards,
Nitin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/