linux-kernel - Re: [PATCH v5 0/4] Qualcomm SPMI PMIC pin controller drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141003235320.GC28481@sonymobile.com>
Date:	Fri, 3 Oct 2014 16:53:21 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>,
	Linus Walleij <linus.walleij@...aro.org>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v5 0/4] Qualcomm SPMI PMIC pin controller drivers

On Wed 01 Oct 09:30 PDT 2014, Ivan T. Ivanov wrote:

> Changes since v4:
> 
> - Use PMIC name in compatible string.
> - PINCTRL_QCOM_SPMI_PMIC from Kconfig symbol.
> - Remove pmic string from drivers file names.
> - Fixed coding style issues.
> - Use qcom-spmi-gpio and qcom-spmi-mpp from dirver names,
>   to be similar to qcom-spmi-iadc, qcom-spmi-vadc and 
>   qcom-spmi-temp-alarm drivers.
> 
> Short description:
> 
> Patches adds pin control drivers for Multi-Purpose Pin (MPP) and
> General-purpose pin (GPIO) controllers found in Qualcomm SPMI based
> PMIC chips.
> 
> MPP's are enhanced GPIO's with analog circuits, which support 
> analog and digital input/output.
> 
> v4: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg725568.html
> 
> Bjorn Andersson (1):
>   pinctrl: Device tree bindings for Qualcomm PMIC GPIO block
> 
> Ivan T. Ivanov (3):
>   pinctrl: Device tree bindings for Qualcomm PMIC MPP block
>   pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver
>   pinctrl: Qualcomm SPMI PMIC MPP pin controller driver
> 
>  .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 215 +++++
>  .../devicetree/bindings/pinctrl/qcom,pmic-mpp.txt  | 162 ++++
>  drivers/pinctrl/qcom/Kconfig                       |  13 +
>  drivers/pinctrl/qcom/Makefile                      |   2 +
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c           | 937 ++++++++++++++++++++
>  drivers/pinctrl/qcom/pinctrl-spmi-mpp.c            | 953 +++++++++++++++++++++
>  include/dt-bindings/pinctrl/qcom,pmic-gpio.h       | 142 +++
>  include/dt-bindings/pinctrl/qcom,pmic-mpp.h        |  44 +
>  8 files changed, 2468 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
>  create mode 100644 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>  create mode 100644 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
>  create mode 100644 include/dt-bindings/pinctrl/qcom,pmic-gpio.h
>  create mode 100644 include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> 

This looks good and I gave it a spin on one of our 8974 devices and verified
that gpio_keys works :)

Acked-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/