linux-kernel - Re: [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141003155001.GB10004@kroah.com>
Date:	Fri, 3 Oct 2014 08:50:01 -0700
From:	Greg KH <greg@...ah.com>
To:	Nathaniel Ting <nathaniel.ting@...abs.com>
Cc:	johan@...nel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.

On Fri, Oct 03, 2014 at 11:06:33AM -0400, Nathaniel Ting wrote:
> From: Nathaniel Ting <nathaniel.ting@...abs.com>
> 
> Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
> driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
> connect to host PCs over a USB serial link.
> 
> Signed-off-by: Nathaniel Ting <nathaniel.ting@...abs.com>
> ---
>  drivers/usb/serial/cp210x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e4bb622..ce81fa8 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
>  	{ USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
>  	{ USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
> +        { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */

Close, but if you ran your patch through checkpatch.pl you would see
that you used spaces instead of tabs for indentation.

At least the tabs on the other lines came through correctly, which is
good.

Care to fix this up and try again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/