linux-kernel - Re: [PATCH v3 3/5] selftests/ipc: change test to use ksft framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <542EFC36.1010306@osg.samsung.com>
Date:	Fri, 03 Oct 2014 13:42:46 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Davidlohr Bueso <dave@...olabs.net>
CC:	akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
	colin.king@...onical.com, luto@...capital.net,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v3 3/5] selftests/ipc: change test to use ksft framework

On 10/03/2014 11:39 AM, Davidlohr Bueso wrote:
> On Fri, 2014-10-03 at 09:36 -0600, Shuah Khan wrote:
>>  	msgque.key = ftok(argv[0], 822155650);
>>  	if (msgque.key == -1) {
>> -		printf("Can't make key\n");
>> -		return -errno;
>> +		printf("Can't make key: %d\n", -errno);
> 
> So printing a numeric value is quite useless when users actually run
> into these errors -- which is why I like err() so much. How about using
> strerror() instead?
> 

Yes. using perror() does give better information. There are other
places in this file that use errno. How about I make that a separate
patch and catch all of them at once to use perror() as a follow-up
change? That way I fix all at once without adding more changes to
this patch.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/