linux-kernel - Re: [PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141003203413.GA18227@kroah.com>
Date:	Fri, 3 Oct 2014 13:34:13 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Giedrius Statkevicius <giedrius.statkevicius@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	fabio.falzoi84@...il.com
Subject: Re: [PATCH 1/5] Combine ifs into one where possible to avoid
 unnecessary indentation level increase

On Fri, Oct 03, 2014 at 11:27:04PM +0300, Giedrius Statkevicius wrote:
> From: Giedrius Statkevičius <giedrius.statkevicius@...il.com>
> 
> Join together chained if's where possible to lower the indentation level.
> 
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@...il.com>

Your subject is "odd", in that it doesn't say what part of the kernel it
is for.  Look at the kernel git logs, it should give you an idea of how
to format things properly.

Also, you don't have to have such a long subject:, try to keep it short,
and then be verbose in the changelog body.

Can you fix up all of these 5 and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/