linux-kernel - Re: [PATCH 02/11] tc90522 is a client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20141005083358.072f5909.m.chehab@samsung.com>
Date:	Sun, 05 Oct 2014 08:33:58 -0300
From:	Mauro Carvalho Chehab <m.chehab@...sung.com>
To:	Буди Романто, AreMa Inc 
	<info@....ma>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	crope@....fi, mchehab@....samsung.com, hdegoede@...hat.com,
	laurent.pinchart@...asonboard.com, mkrufky@...uxtv.org,
	sylvester.nawrocki@...il.com, g.liakhovetski@....de,
	peter.senna@...il.com
Subject: Re: [PATCH 02/11] tc90522 is a client

Em Sun, 05 Oct 2014 17:59:38 +0900
"Буди Романто, AreMa Inc" <info@....ma> escreveu:

> tc90522 is an I2C client functioning as a frontend
> thus, it is enough to return the FE pointer.
> 
> Signed-off-by: Буди Романто, AreMa Inc <knightrider@....ma>
> ---
>  drivers/media/dvb-frontends/tc90522.h | 41 ++++++++++++-----------------------
>  1 file changed, 14 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/tc90522.h b/drivers/media/dvb-frontends/tc90522.h
> index b1cbddf..c78a5b0 100644
> --- a/drivers/media/dvb-frontends/tc90522.h
> +++ b/drivers/media/dvb-frontends/tc90522.h
> @@ -1,12 +1,12 @@
>  /*
> - * Toshiba TC90522 Demodulator
> + * Earthsoft PT3 demodulator frontend Toshiba TC90522XBG OFDM(ISDB-T)/8PSK(ISDB-S)
>   *
> - * Copyright (C) 2014 Akihiro Tsukada <tskd08@...il.com>
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation version 2.
> + * Copyright (C) 2014 Budi Rachmanto, AreMa Inc. <info@....ma>
>   *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
>   *
>   * This program is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> @@ -14,29 +14,16 @@
>   * GNU General Public License for more details.
>   */
>  
> -/*
> - * The demod has 4 input (2xISDB-T and 2xISDB-S),
> - * and provides independent sub modules for each input.
> - * As the sub modules work in parallel and have the separate i2c addr's,
> - * this driver treats each sub module as one demod device.
> - */

None of the above is related to the patch description. Also, we don't
remove copyrights from the driver. 

> -
> -#ifndef TC90522_H
> -#define TC90522_H
> +#ifndef	__TC90522_H__
> +#define	__TC90522_H__
>  
> -#include <linux/i2c.h>
> -#include "dvb_frontend.h"
> -
> -/* I2C device types */
> -#define TC90522_I2C_DEV_SAT "tc90522sat"
> -#define TC90522_I2C_DEV_TER "tc90522ter"
> +#define TC90522_DRVNAME "tc90522"

This would break the driver, as the two macros above are used at
tc90522.c.

>  struct tc90522_config {
> -	/* [OUT] frontend returned by driver */
> -	struct dvb_frontend *fe;
> -
> -	/* [OUT] tuner I2C adapter returned by driver */
> -	struct i2c_adapter *tuner_i2c;
> +	fe_delivery_system_t	type;	/* IN	SYS_ISDBS or SYS_ISDBT */
> +	bool			pwr;	/* IN	set only once after all demods initialized */
> +	struct dvb_frontend	*fe;	/* OUT	allocated frontend */
>  };

A change like that at the struct would break the driver.

There are several problems at the approach you're taking. It seems that
you're just doing a diff from the driver that it is committed from the
driver you have, without:
	- splitting one change par patch;
	- caring if a patch would break compilation.

Instead, if you need, for example, to add a new field at the config struct,
like "pwr", your patch would need to be touching both the header and the
tc90522 to use this new field.

For the same reasons, I can't apply the rest of your patch series, as it is
not splitting the changes as one patch per functional changes.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/