linux-kernel - Re: aesbs-core.S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv+Gu-F_=3CDJuhuiO9O2W4OmC+NFmhJfTbyN-9dPqFW7vJ7Q@mail.gmail.com>
Date:	Mon, 6 Oct 2014 11:33:32 +0200
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Nicolas Pitre <nico@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Nicholas Mc Guire <der.herr@...r.at>
Subject: Re: aesbs-core.S_shipped?

On 1 October 2014 14:48, Christoph Hellwig <hch@...radead.org> wrote:
> On Tue, Sep 30, 2014 at 06:26:19PM +0200, Ard Biesheuvel wrote:
>> > can you explain me why arch/arm/crypto/aesbs-core.S_shipped
>> > is a _shipped file? I can't find any reason why it should be,
>> > it's a normal .S file in every way as far as I can tell.
>>
>> It is generated by aesbs-core.pl, and Russell preferred including it
>> as a _shipped file rather than generating it from the perl script on
>> each build. (Note that the Perl script is kept in sync with OpenSSL,
>> i.e., the goal is to be able to generate the kernel .S and the OpenSSL
>> userland .S from the same script)
>
> Thanks for the explanation.  Can you update the script so that it
> inserts a comment explaining how the file was generated into it?
>
> Also to satisfy the GPL you need to include a copy of aesbs-core.pl in
> the kernel tree.  I only did a quick find -name aesbs-core.pl that
> didn't find any results, so if it's named slightly differently feel
> free to discard this second comment.

Apologies. It is called bsaes-armv7.pl, which is the name it goes by
in the OpenSSL tree. (In the OpenSSL build, the .S is generated during
build time)

-- 
Ard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/