linux-kernel - Re: [PATCH v2 1/2] x86: Add cpu_detect_cache_sizes() to init_intel(), add Quark to legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1410061121470.4383@nanos>
Date:	Mon, 6 Oct 2014 11:55:37 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Bryan O'Donoghue <pure.logic@...us-software.ie>
cc:	mingo@...hat.com, hpa@...or.com, davej@...hat.com, hmh@....eng.br,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] x86: Add cpu_detect_cache_sizes() to init_intel(),
 add Quark to legacy_cache()

On Sat, 4 Oct 2014, Bryan O'Donoghue wrote:
> @@ -381,7 +381,18 @@ static void init_intel(struct cpuinfo_x86 *c)
>  #endif
>  	}
>  
> -	l2 = init_intel_cacheinfo(c);
> +	/* Detect legacy cache sizes */
> +	cpu_detect_cache_sizes(c);
> +
> +	/*
> +	 * If cache_size has not been initialized via legacy_cache()
> +	 * probe it via init_intel_cacheinfo().
> +	 */
> +	if (c->x86_cache_size == 0)
> +		l2 = init_intel_cacheinfo(c);
> +	else
> +		l2 = c->x86_cache_size;

Looking a bit deeper. This wont work because cpu_detect_cache_sizes()
will set c->x86_cache_size for all cpus with extended_cpuid_level >=
0x80000005, which is the case for everything modern. So this results
in init_intel_cacheinfo() not being called anymore.

So we might need the following conditional:

	l2 = init_intel_cacheinfo(c);
+	if (!c->x86_cache_size) {
+		cpu_detect_cache_sizes(c);
+		l2 = c->x86_cache_size;
+	}

If that does not work because c->x86_cache_size is not 0 after
init_intel_cacheinfo() we really need to make it family/model
dependent.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/