lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 06 Oct 2014 16:07:32 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH 09/16] virtio-net: drop config_mutex

On 10/6/2014 3:56 PM, Michael S. Tsirkin wrote:

>>> config_mutex served two purposes: prevent multiple concurrent config
>>> change handlers, and synchronize access to config_enable flag.

>>> Since commit dbf2576e37da0fcc7aacbfbb9fd5d3de7888a3c1
>>>      workqueue: make all workqueues non-reentrant
>>> all workqueues are non-reentrant, and config_enable
>>> is now gone.

>>> Get rid of the unnecessary lock.

>>> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
>>> ---
>>>   drivers/net/virtio_net.c | 7 +------
>>>   1 file changed, 1 insertion(+), 6 deletions(-)

>>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>>> index fa17afa..d80fef4 100644
>>> --- a/drivers/net/virtio_net.c
>>> +++ b/drivers/net/virtio_net.c
>> [...]
>>> @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work)
>>>   		netif_tx_stop_all_queues(vi->dev);
>>>   	}
>>>   done:
>>> -	mutex_unlock(&vi->config_lock);
>>> +	return;

>>     There's no need for this *return*.

> I know - it's removed by the follow-up patch.

    Yeah, I saw.

> It's formatted like this to make diff smaller
> and make review easier.

    Don't understand how adding this line makes diff smaller though...
You first need to add it and then to delete it, where's the save?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists