linux-kernel - Re: [PATCH V5 08/13] sched: add a macro to ref all CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141006124702.GW1992@madcap2.tricolour.ca>
Date:	Mon, 6 Oct 2014 08:47:02 -0400
From:	Richard Guy Briggs <rgb@...hat.com>
To:	"Chen, Hanxiao" <chenhanxiao@...fujitsu.com>
Cc:	"linux-audit@...hat.com" <linux-audit@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"containers@...ts.linux-foundation.org" 
	<containers@...ts.linux-foundation.org>,
	"eparis@...hat.com" <eparis@...hat.com>,
	"pmoore@...hat.com" <pmoore@...hat.com>,
	"aviro@...hat.com" <aviro@...hat.com>,
	"sgrubb@...hat.com" <sgrubb@...hat.com>,
	"ebiederm@...ssion.com" <ebiederm@...ssion.com>
Subject: Re: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags

On 14/10/06, Chen, Hanxiao wrote:
> 
> 
> > -----Original Message-----
> > From: containers-bounces@...ts.linux-foundation.org
> > [mailto:containers-bounces@...ts.linux-foundation.org] On Behalf Of Richard Guy
> > Briggs
> > Sent: Monday, October 06, 2014 1:09 PM
> > To: linux-audit@...hat.com; linux-kernel@...r.kernel.org;
> > containers@...ts.linux-foundation.org
> > Cc: eparis@...hat.com; pmoore@...hat.com; aviro@...hat.com; sgrubb@...hat.com;
> > ebiederm@...ssion.com
> > Subject: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags
> > 
> > ---
> >  include/uapi/linux/sched.h |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> > index 34f9d73..5aceba2 100644
> > --- a/include/uapi/linux/sched.h
> > +++ b/include/uapi/linux/sched.h
> > @@ -28,6 +28,12 @@
> >  #define CLONE_NEWUSER		0x10000000	/* New user namespace */
> >  #define CLONE_NEWPID		0x20000000	/* New pid namespace */
> >  #define CLONE_NEWNET		0x40000000	/* New network namespace */
> > +#define CLONE_NEW_MASK	( CLONE_NEWNS \
> > +			| CLONE_NEWUTS \
> > +			| CLONE_NEWIPC \
> > +			| CLONE_NEWUSER \
> > +			| CLONE_NEWPID \
> > +			| CLONE_NEWNET)	/* mask of all namespace type flags */
> >  #define CLONE_IO		0x80000000	/* Clone io context */
> 
> The name 'CLONE_NEW_MASK' may confuse readers.
> How about something like CLONE_NEW_MASK_ALL?

Fair enough.  Changed.

> Thanks,
> - Chen

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/