linux-kernel - Re: [PATCH] mips: Convert pr_warning to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Oct 2014 05:54:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	linux-mips <linux-mips@...ux-mips.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mips: Convert pr_warning to pr_warn

On Mon, 2014-10-06 at 14:49 +0200, Ralf Baechle wrote:
> On Sat, Oct 04, 2014 at 09:50:42AM -0700, Joe Perches wrote:
> 
> > Use the much more common pr_warn instead of pr_warning
> > with the goal of removing pr_warning eventually.
> 
> While I agree that only one of pr_warn and pr_warning deserves to live
> picking pr_warning introduces another logic inconsistency - for each
> pr_<foo> function there is a KERN_<FOO> severity symbol.  And that in
> this case is named KERN_WARNING, there's no KERN_WARN.

Yes, I know.  It's a consistency thing that can really
only be resolved one step at a time.

Most everything else uses _warn (dev_warn, netdev_warn,
etc...) so it'd be good to get pr_warn done too.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/