linux-kernel - Re: [PATCH] ARM: OMAP2: Remove unnecessary KERN_* in omap_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141006162151.GA21908@kahuna>
Date:	Mon, 6 Oct 2014 11:21:51 -0500
From:	Nishanth Menon <nm@...com>
To:	Masanari Iida <standby24x7@...il.com>
CC:	<tony@...mide.com>, <linux@....linux.org.uk>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] ARM: OMAP2: Remove unnecessary KERN_* in
 omap_phy_internal.c

On 01:16-20141007, Masanari Iida wrote:
> This patch remove unnecessary KERN_INFO and KERN_ERR from omap_phy_internal.c.
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
>  arch/arm/mach-omap2/omap_phy_internal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
> index 50640b3..f4d942a 100644
> --- a/arch/arm/mach-omap2/omap_phy_internal.c
> +++ b/arch/arm/mach-omap2/omap_phy_internal.c

With the cleanups, maybe add a
#define pr_fmt(fmt) "%s: " fmt, __func__
at the start to make the log info a little more relevant?

> @@ -97,13 +97,13 @@ void am35x_musb_phy_power(u8 on)
>  
>  		omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
>  
> -		pr_info(KERN_INFO "Waiting for PHY clock good...\n");
> +		pr_info("Waiting for PHY clock good...\n");
>  		while (!(omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2)
>  				& CONF2_PHYCLKGD)) {
>  			cpu_relax();
>  
>  			if (time_after(jiffies, timeout)) {
> -				pr_err(KERN_ERR "musb PHY clock good timed out\n");
> +				pr_err("musb PHY clock good timed out\n");
>  				break;
>  			}
>  		}
> @@ -145,7 +145,7 @@ void am35x_set_mode(u8 musb_mode)
>  		devconf2 |= CONF2_NO_OVERRIDE;
>  		break;
>  	default:
> -		pr_info(KERN_INFO "Unsupported mode %u\n", musb_mode);
> +		pr_info("Unsupported mode %u\n", musb_mode);
>  	}
>  
>  	omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
> -- 
> 2.1.1.273.g97b8860
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/