linux-kernel - Re: [PATCH v3] clocksource: arch_timer: Allow the device tree to specify uninitialized CNTVOFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2943095.1HCacZ7zIg@wuerfel>
Date:	Tue, 07 Oct 2014 09:40:57 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Sonny Rao <sonnyrao@...omium.org>,
	Mark Rutland <Mark.Rutland@....com>,
	devicetree@...r.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	Marc Zyngier <marc.zyngier@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Will Deacon <will.deacon@....com>,
	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	Doug Anderson <dianders@...omium.org>, galak@...eaurora.org,
	Sudeep Holla <Sudeep.Holla@....com>,
	Olof Johansson <olof@...om.net>,
	Nathan Lynch <Nathan_Lynch@...tor.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH v3] clocksource: arch_timer: Allow the device tree to specify uninitialized CNTVOFF

On Monday 06 October 2014 23:37:32 Sonny Rao wrote:
> 
> +#ifdef CONFIG_ARM
> +       /*
> +        * If we cannot rely on firmware initializing the CNTVOFF then
> +        * we should use the physical timers instead.
> +        */
> +       if (of_property_read_bool(np, "arm,cntvoff-not-fw-configured"))
> +               arch_timer_use_virtual = false;
> +#endif
> +
> 

Sorry for the nitpicking, but can this please use

	if (IS_ENABLED(CONFIG_ARM))

to avoid the ugly #ifdef?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/