linux-kernel - Re: [PATCH] Kbuild: Check for CONFIG_READABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Oct 2014 14:27:07 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kbuild@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	X86 ML <x86@...nel.org>
Subject: Re: [PATCH] Kbuild: Check for CONFIG_READABLE_ASM when building .s
 targets

On Tue, Oct 07, 2014 at 02:13:56PM +0200, Michal Marek wrote:
> This violates the principle of least surprise:
> 
> make $file.s
> as -o $file.o $file.s
> 
> should be equivalent to
> 
> make $file.o

I know but we need to enable -g for .s targets so that we get the .loc
annotation (i.e., line numbers) in asm which is very helpful.

But the least surprise principle is a valid point. Maybe we should warn
about it too when building .s targets...?

Or, maybe I should try to find out whether there's another gcc option
which adds ".loc" annotations alone...

> Why not simply check both READABLE_ASM and DEBUG_INFO?  Also, it's more
> straightforward to print the warning in the top-level Makefile rule than
> to add a conditional to the generic rule, like this:

The problem here is that we're building a couple of .s targets
regardless of what the make command contains, like bounds.s and such.

And we want to issue the warning only when we have an .s file as
an explicit target on the command line. That's why I'm doing that
asm_target assignment dance and something similar to WARN_ON_ONCE...

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/