linux-kernel - Re: [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141007125221.GG4609@sirena.org.uk>
Date:	Tue, 7 Oct 2014 13:52:21 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Gyungoh Yoo <gyungoh@...il.com>
Cc:	lgirdwood@...il.com, grant.likely@...aro.org, robh+dt@...nel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	jack.yoo@...worksinc.com
Subject: Re: [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible
 string for device binding

On Tue, Oct 07, 2014 at 02:11:07PM +0900, Gyungoh Yoo wrote:
> Signed-off-by: Gyungoh Yoo <jack.yoo@...worksinc.com>

Several problems here:

 - I don't have patches 1-6 or the cover letter for this series - what
   are the dependencies?
 - I can't see any sign that my concerns about the driver not actually
   being reusable have been addressed here.
 - This patch appears to do way more than add a compatible string, for
   example:

> -	np = of_get_child_by_name(dev->parent->of_node, "regulator");
> -	if (unlikely(!np)) {
> +	if (!np) {
>  		dev_err(dev, "regulator node not found");
> -		return NULL;
> +		return ERR_PTR(-ENODATA);

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)