linux-kernel - Re: [PATCH v3 1/2] power: reset: add LTC2952 poweroff support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5433E7A3.4080707@roeck-us.net>
Date:	Tue, 07 Oct 2014 06:16:19 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Frans Klaver <frans.klaver@...ns.com>
CC:	Sebastian Reichel <sre@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] power: reset: add LTC2952 poweroff support

On 10/07/2014 01:15 AM, Frans Klaver wrote:
> On Mon, Oct 06, 2014 at 02:32:10PM -0700, Guenter Roeck wrote:

>> Any reason for not using devm_gpiod_get() for those functions ?
>
> René said in the first review round:
>
>>>>   devm_* functions do not seem to common to me and are sparsely
>>>>   documented, therefore I preferred the regular functions. This
>>>>   error jump should go to err_io and the clean-up loop must check
>>>>   if the gpio entry is actually filled in
>
> I now unrolled these loops, and quite frankly I'm not that sure devm_*
> functions are actually that sparsely used. The way to get around that is
> to use them more. I'll see about using those instead, maybe add some
> documentation as well.
>

"git grep devm_| wc" on 3.17 returns 7344.

If that is not enough, nothing ever will.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/