linux-kernel - Re: [PATCH] mnt: don't allow to detach the namespace root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141007132431.GF7996@ZenIV.linux.org.uk>
Date:	Tue, 7 Oct 2014 14:24:36 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrey Vagin <avagin@...nvz.org>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Serge Hallyn <serge.hallyn@...onical.com>
Subject: Re: [PATCH] mnt: don't allow to detach the namespace root

On Tue, Oct 07, 2014 at 04:00:12PM +0400, Andrey Vagin wrote:
> This patch fixes a bug, which is triggered by following code:
> while (1) {
>         if (umount2("/", MNT_DETACH) ||
> 	    setns(fd, CLONE_NEWNS))
>                 return break;
> }

Excuse me, but that makes no sense whatsoever (not to mention that
reproducer won't compile - return break; alone is enough to make
sure of that).

Could you post the real reproducer?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/