linux-kernel - Re: [PATCH] perf kvm stat record: print kvm specific --help output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Oct 2014 12:14:12 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Alexander Yarygin <yarygin@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org,
	Christian Borntraeger <borntraeger@...ibm.com>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] perf kvm stat record: print kvm specific --help output

Em Tue, Oct 07, 2014 at 09:10:46AM -0600, David Ahern escreveu:
> On 10/6/14, 10:13 AM, Alexander Yarygin wrote:
> 
> >+static void print_record_help(void)
> >+{
> >+	fprintf(stderr, "\n usage: perf kvm stat record [<options>]\n\n");
> >+
> >+	fprintf(stderr, "    -p, --pid <pid>      record events on existing process id\n");
> >+	fprintf(stderr, "    -t, --tid <tid>      record events on existing thread id\n");
> >+	fprintf(stderr, "    -r, --realtime <n>   collect data with this RT SCHED_FIFO priority\n");
> >+	fprintf(stderr, "        --no-buffering   collect data without buffering\n");
> >+	fprintf(stderr, "    -a, --all-cpus       system-wide collection from all CPUs\n");
> >+	fprintf(stderr, "    -C, --cpu <cpu>      list of cpus to monitor\n");
> >+	fprintf(stderr, "    -c, --count <n>      event period to sample\n");
> >+	fprintf(stderr, "    -o, --output <file>  output file name\n");
> >+	fprintf(stderr, "    -i, --no-inherit     child tasks do not inherit counters\n");
> >+	fprintf(stderr, "    -m, --mmap-pages <pages>\n");
> >+	fprintf(stderr, "                         number of mmap data pages\n");
> >+	fprintf(stderr, "    -v, --verbose        be more verbose (show counter open errors, etc)\n");
> >+	fprintf(stderr, "    -q, --quiet          don't print any message\n");
> >+	fprintf(stderr, "    -D, --delay <n>      ms to wait before starting measurement after program start\n");
> >+	fprintf(stderr, "    -u, --uid <user>     user to profile\n");
> >+	fprintf(stderr, "        --per-thread     use per-thread mmaps\n");
> >+
> >+	fprintf(stderr, "\nOtherwise, it is the alias of 'perf record:'\n");
> >+}
> 
> Those are all perf-record options, not perf-kvm-stat-record options. This
> usage should not repeat perf-record.

Right, and from a quick look, the way Namhyung is tackling this problem
is better.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/