lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue,  7 Oct 2014 16:19:23 -0700
From:	Greg Kroah-Hartman <>
Cc:	Greg Kroah-Hartman <>,, Andy Gross <>,
	Felipe Balbi <>,
	Bjorn Andersson <>,
	Wolfram Sang <>
Subject: [PATCH 3.16 07/26] i2c: qup: Fix order of runtime pm initialization

3.16-stable review patch.  If anyone has any objections, please let me know.


From: Andy Gross <>

commit 86b59bbfae2a895aa26b3d15f31b1a705dbfede1 upstream.

The runtime pm calls need to be done before populating the children via the
i2c_add_adapter call.  If this is not done, a child can run into issues trying
to do i2c read/writes due to the pm_runtime_sync failing.

Signed-off-by: Andy Gross <>
Reviewed-by: Felipe Balbi <>
Acked-by: Bjorn Andersson <>
Signed-off-by: Wolfram Sang <>
Signed-off-by: Greg Kroah-Hartman <>

 drivers/i2c/busses/i2c-qup.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -670,16 +670,20 @@ static int qup_i2c_probe(struct platform
 	qup-> = pdev->dev.of_node;
 	strlcpy(qup->, "QUP I2C adapter", sizeof(qup->;
-	ret = i2c_add_adapter(&qup->adap);
-	if (ret)
-		goto fail;
 	pm_runtime_set_autosuspend_delay(qup->dev, MSEC_PER_SEC);
+	ret = i2c_add_adapter(&qup->adap);
+	if (ret)
+		goto fail_runtime;
 	return 0;
+	pm_runtime_disable(qup->dev);
+	pm_runtime_set_suspended(qup->dev);
 	return ret;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists