linux-kernel - Re: [PATCH v1] PCI: tegra: Enable root port specific features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141008074738.GE4999@ulmo>
Date:	Wed, 8 Oct 2014 09:47:39 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Vidya Sagar <vidyas@...dia.com>
Cc:	bhelgaas@...gle.com, swarren@...dotorg.org, kthota@...dia.com,
	linux-tegra@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] PCI: tegra: Enable root port specific features

On Wed, Oct 08, 2014 at 09:44:05AM +0200, Thierry Reding wrote:
> On Tue, Oct 07, 2014 at 03:57:58PM +0530, Vidya Sagar wrote:
[...]
> > +static inline void rp_writel(struct tegra_pcie_port *port, u32 value,
> > +							 unsigned long offset)
> > +{
> > +	writel(value, offset + port->base);
> > +}
> > +
> > +static inline unsigned int rp_readl(struct tegra_pcie_port *port,
> 
> readl() returns u32 and so should rp_readl().
> 
> > +							unsigned long offset)
> > +{
> > +	return readl(offset + port->base);
> > +}
> 
> I don't see much use in these, but if you really want to add them,
> please also replace any of the open-coded occurrences of this. Also
> please fix the alignment of function arguments on subsequent lines.
> They should align with the first argument on the first line.

Oh, and perhaps make it a separate (precursory) patch so that this
patch can focus on the PM features.

Thierry

Content of type "application/pgp-signature" skipped