linux-kernel - Re: [PATCH] staging: rtl8712: fix unnecessary elses after return/break in rtl8712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 07 Oct 2014 18:03:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Serguey Parkhomovsky <sergueyparkhomovsky@...il.com>
Cc:	gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
	florian.c.schilhabel@...glemail.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: fix unnecessary elses after
 return/break in rtl8712_efuse.c

On Tue, 2014-10-07 at 16:48 -0700, Serguey Parkhomovsky wrote:
> This patch fixes two unnecessary else conditions that were found by checkpatch.pl.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
[]
> @@ -414,19 +414,19 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
[]
> +		/* call rescue procedure */
> +		if (fix_header(padapter, efuse_data, efuse_addr) ==
> +		    false)
> +			return false; /* rescue fail */

Probably better as:

		if (!fix_header(padapter, efuse_data, efuse_addr))
			return false;	/* rescue fail */



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/