linux-kernel - Re: [PATCH v4 18/29] nios2: Signal handling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvyjd8kA=QwFEju4zWG-ntYsRHnk6p4Sh6Rf_GJQuDR1tw@mail.gmail.com>
Date:	Wed, 8 Oct 2014 13:29:33 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Ley Foon Tan <lftan@...era.com>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	LeyFoon Tan <lftan.linux@...il.com>, cltang@...esourcery.com
Subject: Re: [PATCH v4 18/29] nios2: Signal handling support

On Wed, Oct 8, 2014 at 11:29 AM, Ley Foon Tan <lftan@...era.com> wrote:
> This patch adds support for signal handling.
>
> Signed-off-by: Ley Foon Tan <lftan@...era.com>

Maybe I'm misreading your code but where do you check for multiple
pending signals?
It looks like you're handling only exact one signal before retuning to
userspace.
This is a serious issue, if you post a SIGSEGV i.e. in
do_rt_sigreturn() you need to handle it later
instead of directly returning to userspace.

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/