linux-kernel - Re: [PATCH v7]pwm: add BCM2835 PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141008121935.GB7357@ulmo.nvidia.com>
Date:	Wed, 8 Oct 2014 14:19:37 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Bart Tanghe <bart.tanghe@...masmore.be>
Cc:	matt.porter@...aro.org, linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH v7]pwm: add BCM2835 PWM driver

On Wed, Oct 08, 2014 at 12:14:32PM +0200, Bart Tanghe wrote:
> Add pwm driver for Broadcom BCM2835 processor (Raspberry Pi)
> 
> Signed-off-by: Bart Tanghe <bart.tanghe@...masmore.be>
> ---
> Changed in v7:
>  - clean up the shameful clk_enable error handling introduced in v6
>  - clean up the code nits
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt
> new file mode 100644
> index 0000000..d5162db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt
> @@ -0,0 +1,27 @@
> +BCM2835 PWM controller (Raspberry Pi controller)
> +
> +Required properties:
> +- compatible: should be "brcm,bcm2835-pwm"
> +- reg: physical base address and length of the controller's registers
> +- clock: this clock defines the base clock frequency of the pwm
> +hardware system, the period and the duty_cycle of the pwm signal is a
> +multiple of the base period

This needs to document the #pwm-cells property. I can fix that up when
applying, though.

Let's give Stephen and others a chance to give this another look.

Thierry

Content of type "application/pgp-signature" skipped