linux-kernel - vdso_standalone_test_x86.c build failure on Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA5BeRMd28CUZPj+G2VbcwT0pG7gERk65xdMLXSp_59-RA@mail.gmail.com>
Date:	Wed, 8 Oct 2014 14:52:39 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Peter Foley <pefoley2@...oley.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Jiri Kosina <jkosina@...e.cz>,
	Andy Lutomirski <luto@...capital.net>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: vdso_standalone_test_x86.c build failure on Linus' tree

I'm seeing the following build failure on a 32-bit x86 build in Fedora
based on Linux v3.17-2860-gef0625b70dac:

Documentation/vDSO/vdso_standalone_test_x86.o: In function `to_base10':
vdso_standalone_test_x86.c:(.text+0xcc): undefined reference to `__umoddi3'
vdso_standalone_test_x86.c:(.text+0xea): undefined reference to `__udivdi3'
collect2: error: ld returned 1 exit status
scripts/Makefile.host:100: recipe for target
'Documentation/vDSO/vdso_standalone_test_x86' failed
make[2]: *** [Documentation/vDSO/vdso_standalone_test_x86] Error 1
scripts/Makefile.build:404: recipe for target 'Documentation/vDSO' failed
make[1]: *** [Documentation/vDSO] Error 2
make[1]: *** Waiting for unfinished jobs....
Makefile:922: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 2

Looking at some of the git logs around this, it seems that
vdso_standalone_test_x86.c is 64-bit specific, so I was curious why it
was even being built on a 32-bit build.  Seems this commit:

commit adb19fb66eeebac07fe37d968725bb8906dadb8e
Author: Peter Foley <pefoley2@...oley.com>
Date:   Thu Sep 25 11:23:09 2014 -0700

    Documentation: add makefiles for more targets

    Add a bunch of previously unbuilt source files to the Documentation build
    machinery.

    Signed-off-by: Peter Foley <pefoley2@...oley.com>
    Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
    Signed-off-by: Jiri Kosina <jkosina@...e.cz>

blindly added it to the build target.

So is vdso_standalone_test_x86.c really 64-bit specific?  If so,
should that commit be reverted (or a hunk of it anyway), should there
be some mechanism to not build it on 32-bit, or should there be some
additional CFLAGS passed?

josh

Full build log here:
http://koji.fedoraproject.org/koji/getfile?taskID=7802438&name=build.log
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/