linux-kernel - Re: [PATCH v2] staging: rtl8712: fix unnecessary elses after return/break in rtl8712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141008081251.GA27404@fedora.localdomain>
Date:	Wed, 8 Oct 2014 01:12:51 -0700
From:	Serguey Parkhomovsky <xindigo@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
	florian.c.schilhabel@...glemail.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8712: fix unnecessary elses after
 return/break in rtl8712_efuse.c

> 
> This sort of test is generally better where the
> individual tests are written on separate lines like:
> 
> 			if ((data[idx] != pktdata[i]) ||
> 			    (data[idx+1] != pktdata[i+1])) {
> 

Thanks for all the suggestions, Joe. I'll upload a revised patch soon.

Serguey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/