linux-kernel - Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Oct 2014 21:11:41 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	linux-serial@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls.

On Wed, 2014-10-08 at 21:57 +0200, Ricardo Ribalda Delgado wrote:
> The following drivers: 8250_core, atmel_serial, max310x, mcf, omap-serial
> and sci16is7xx implement code to handle RS485 ioctls.

>  
> +static int uart_get_rs485_config(struct uart_port *port,
> +			 struct serial_rs485 __user *rs485)
> +{
> +	if (!port->rs485_config)
> +		return -ENOIOCTLCMD;
> +
> +	if (copy_to_user(rs485, &port->rs485, sizeof(port->rs485)))
> +		return -EFAULT;
> +	return 0;
> +}
> +
> +static int uart_set_rs485_config(struct uart_port *port,
> +			 struct serial_rs485 __user *rs485_user)
> +{
> +	struct serial_rs485 rs485;
> +	int ret;
> +
> +	if (!port->rs485_config)
> +		return -ENOIOCTLCMD;
> +
> +	if (copy_from_user(&rs485, rs485_user, sizeof(rs485_user)))
> +		return -EFAULT;
> +
> +	ret = port->rs485_config(port, &rs485);
> +	if (ret)
> +		return ret;
> +
> +	if (copy_to_user(rs485_user, &port->rs485, sizeof(port->rs485)))
> +		return -EFAULT;
> +
> +	return 0;
> +

What is the locking between setting/getting/driver use of the config ?
This really needs a lock (termios sem I think is perhaps appropriate
given when the values are normally referenced).

Alan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/