lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Wed,  8 Oct 2014 22:27:27 +0200
From:	Fabian Frederick <fabf@...net.be>
To:	linux-kernel@...r.kernel.org
Cc:	Fabian Frederick <fabf@...net.be>, Sage Weil <sage@...tank.com>,
	ceph-devel@...r.kernel.org
Subject: [PATCH 1/1 linux-next] ceph: return error code directly.

Testing err before returning value is not needed.

Signed-off-by: Fabian Frederick <fabf@...net.be>
---
 fs/ceph/ioctl.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/ceph/ioctl.c b/fs/ceph/ioctl.c
index a822a6e..b2d777a 100644
--- a/fs/ceph/ioctl.c
+++ b/fs/ceph/ioctl.c
@@ -54,10 +54,7 @@ static long __validate_layout(struct ceph_mds_client *mdsc,
 			break;
 		}
 	mutex_unlock(&mdsc->mutex);
-	if (err)
-		return err;
-
-	return 0;
+	return err;
 }
 
 static long ceph_ioctl_set_layout(struct file *file, void __user *arg)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ