linux-kernel - Re: [PATCH] input: avoid negative input device numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141008234927.5c4b8492@frodo>
Date:	Wed, 8 Oct 2014 23:49:27 +0200
From:	Richard Leitner <me@...l1n.net>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	richard.leitner@...data.com
Subject: Re: [PATCH] input: avoid negative input device numbers

On Wed, 8 Oct 2014 14:30:51 -0700
Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:

> On Wed, Oct 08, 2014 at 02:25:38PM -0700, Dmitry Torokhov wrote:
> > On Wed, Oct 08, 2014 at 10:42:45PM +0200, Richard Leitner wrote:
> > > From: Richard Leitner <richard.leitner@...data.com>
> > > 
> > > Fix the format string for input device name generation to avoid
> > > negative device numbers when the id exceeds the maximum signed
> > > integer value.
> > 
> > Well, it is going to take us a while to get there :)
> > 
> > Applied, thank you.
> 
> By the way, we have similar issue in serio and gameport code, mind
> sending fixes for them as well?
> 
I'll send a patch for the serio in a few minutes.

The gameport code looks fine to me:

536		dev_set_name(&gameport->dev, "gameport%lu",
537				(unsigned long)atomic_inc_return(&gameport_no) - 1);

regards,
richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/